Consistent big O notation in map.rs #90239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Now that I look at it closer, isn't there an 'O' missing here in https://github.com/rust-lang/rust/blob/master/library/alloc/src/collections/btree/map.rs#L39 for (log2n)? In that case I could fix that up in this PR too. |
|
Was this supposed to be big O? I think expressing it like "B * log(n) comparisons" is fine. Also, the line you linked is correct.
|
|
@fee1-dead Alright, that's cleared up then! I removed the big O notation. |
ghost
|
@bors r+ rollup |
|
📌 Commit b1b4c6c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2021
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#90239 (Consistent big O notation in map.rs) - rust-lang#90267 (fix: inner attribute followed by outer attribute causing ICE) - rust-lang#90288 (Add hint for people missing `TryFrom`, `TryInto`, `FromIterator` import pre-2021) - rust-lang#90304 (Add regression test for rust-lang#75961) - rust-lang#90344 (Add tracking issue number to const_cstr_unchecked) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #89216